Contact Us form "Other" errors when data is entered : sendmessage.php line 229

[محروم.كوم]

Hi
We just up upgraded from 3.8.4 to 3.8.5.

We saw the following error:
Contact Us form had a problem when the Subject radio button was chosen as "Other" even if you do type something in the associated text field. The error message stating that the Subject and Message were not entered even though something was written in the Other text field and a message was written in the Message text area.

Looking at forum/sendmessage.php line 229

// check we have a message and a subject

if ($message == '' OR $subject == ''
OR (
$vbulletin->options['contactusoptions']
AND $subject == 'other'
AND ($vbulletin->GPC['other_subject'] == '' OR !$vbulletin->options['contactusother'])
)
)
{
$errors[] = fetch_error('nosubject');
}

It seems as though $vbulletin->options['contactusother'] is not defined which would make that OR portion always true when the subject is other. We changed that clause to:

// check we have a message and a subject
if ($message == '' OR $subject == ''
OR (
$vbulletin->options['contactusoptions']
AND $subject == 'other'
AND ($vbulletin->GPC['other_subject'] == '')
)
)
{
$errors[] = fetch_error('nosubject');
}

The problem is now gone. Was this an error on our part somehow in the upgrade or is this a bug?

Thanks for your time looking !
Sincerely,
adam7 __DEFINE_LIKE_SHARE__