Why do you have a variable assignment in query_xx($foo = "select...))
 

Resulting from the idea of pitchu i have a question,


Why do you make something like: PHP Code:
$db = $vbulletin->db;
$set = $db->query($q = "
SELECT searchlog.*
FROM " . TABLE_PREFIX . "searchlog AS searchlog
WHERE searchhash = '" . $db->escape_string($criteria->get_hash()) . "' AND
sortby = '" . $db->escape_string($criteria->get_sort()) . "' AND
sortorder = '" . $db->escape_string($criteria->get_sort_direction()) . "' AND
dateline > " . (TIMENOW - (60*60)) . " AND
userid = " . intval($user->get_field('userid')) . " AND
completed = 1
ORDER BY dateline DESC
LIMIT 1
");

really hard to read and make automatic code checking (what i made yesterday and you see the result in the tracker ;) ) impossible ;)

I don't see any result / benefit from it. Is there one? If there is a sense, it's ok for me and maybe i can learn something you:)

It just needs maybe more memory and time (because of the var. assignment) I wrote maybe because i'm not sure if it needs really more memory and time. Some people say it needs more and some not...