Importing Attachments from PHPbb 3 to vBulletin 4. Is the code complete?
 

Type of import: Clean
Source board system and version: PHPbb 3.0.6
Target version: 4.0.1
Module issue occurred on: 010.php:init(), ImpExDatabase_400.php:import_attachment()
ImpEx version: 1.95

After 6 hours of tracing, I've found a couple issues.

In ImpExDatabase_400.php, import_attachment(), lines 147 - 203 are commented out and $attachfile at line 114 is 2 so the needed case isn't being hit, the default is (this ALWAYS returns false) so calls to import_attachment() from 010.php:resume() always fail.

Even after making that case available I found that lines 103 to 109 aren't behaving as I expect they're intended to. I would expect to see an insert in between, but perhaps one is happening prior and I'm missing it. Either way, $Db_object->insert_id() on line 109 ALWAYS returns 0 and as a result each call to import_attachment() returns 0, again failing the attachment from what I can tell.

I've added LOADS of trace information via $displayobject->display_now() to realize this. It makes me thing (especially from what I'm reading of other experience) that ImpEx just isn't intended to import attachments from PHPbb 3 to VB4.

I'll gladly help further if a dev can do so much as confirm/deny my findings, but it seems to me that inserts into the attachment table need to happen sooner in the flow than they are or this approach can't work (perhaps why the code is commented out).

I'll even see about making it work properly and only ask for an additional license in return ;)